This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
fix(incidents): add loading during fetch phase #2085
Merged
jackcmeyer
merged 7 commits into
HospitalRun:master
from
marcosvega91:fix/view_incident
May 20, 2020
Merged
fix(incidents): add loading during fetch phase #2085
jackcmeyer
merged 7 commits into
HospitalRun:master
from
marcosvega91:fix/view_incident
May 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/hospitalrun/hospitalrun-frontend/c6yb2e9ke |
jackcmeyer
added
incidents
patients
issue/pull request that interacts with patients module
🚀enhancement
an issue/pull request that adds a feature to the application
labels
May 17, 2020
jackcmeyer
removed
the
patients
issue/pull request that interacts with patients module
label
May 17, 2020
matteovivona
changed the title
fix(viewincident): add loading during fetch phase
fix(incidents): add loading during fetch phase
May 17, 2020
jackcmeyer
suggested changes
May 17, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few changes requested.
</Row> | ||
</> | ||
) | ||
if (incident) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a loading status as part of the incident slice that we should add into this check as well.
jackcmeyer
approved these changes
May 20, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #2081
Changes proposed in this pull request: